Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update subscription modal for ClusterSubscription info #236

Merged
merged 7 commits into from
Mar 3, 2020
Merged

update subscription modal for ClusterSubscription info #236

merged 7 commits into from
Mar 3, 2020

Conversation

dalehille
Copy link
Contributor

@dalehille dalehille commented Feb 24, 2020 •
edited
Loading

implements #234

image

@mckaymic
Copy link
Contributor

mckaymic commented Mar 3, 2020

Can you put a collapsable section in the information to show the user's userid and api-key? This way they don't have to exit the dialog to get the information.

mckaymic
mckaymic suggested changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@mckaymic mckaymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my last comment regarding make the userid and api-key available also

@dalehille dalehille merged commit 2d3a440 into master Mar 3, 2020
@dalehille dalehille deleted the pub_sub_configmap branch March 3, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckaymic mckaymic mckaymic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dalehille @mckaymic